test: Migrate Frontend tests to a GHA Workflow #10923
Conversation
DharmitD
changed the title
DharmitD
changed the title
Find PR to remove the frontend test from prow config here: GoogleCloudPlatform/oss-test-infra#2302 |
| branches: | ||
| - master | ||
| paths: | ||
| - 'frontend/**' |
There was a problem hiding this comment.
I think we should also add this workflow itself.
| - 'frontend/**' | |
| - 'frontend/**' | |
| - '.github/workflows/frontend.yml' |
There was a problem hiding this comment.
done, added this workflow to paths.
| @@ -92,7 +92,6 @@ | |||
| "test:server:coverage": "cd ./server && npm test -- --coverage && cd ..", | |||
| "test:coverage": "npm test -- --coverage && npm run test:server:coverage", | |||
| "test:ci": "export CI=true && npm run format:check && npm run lint && npm run test:coverage", | |||
| "test:ci:prow": "npm set unsafe-perm true && npm ci && npm run test:ci && ./scripts/report-coveralls.sh", | |||
There was a problem hiding this comment.
We can also remove the ./scripts/report-coveralls.sh and frontend/scripts/get-coveralls-repo-token.js files. Seems like they are no longer referenced with this change.
There was a problem hiding this comment.
Done, removed these files.
Signed-off-by: ddalvi <[email protected]>
|
@DharmitD: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This PR is ready for review. |
|
/lgtm |
|
@chensun could you please approve? |
|
@chensun could you also approve GoogleCloudPlatform/oss-test-infra#2302? cc: @zijianjoy @james-jwu |
|
/retest-required |
|
Closing this PR and re-opening so that the tide check runs using latest config. |
|
Reopening. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Duplicated here: #10972 |
Description of your changes:
Resolves #10879
Converts the Prow frontend test to a GH Action Workflow.
Here's a working GH Action run on my fork: https://github.com/DharmitD/data-science-pipelines-argo/actions/runs/9525123655/job/26258863870
PR to remove the frontend test from prow config: GoogleCloudPlatform/oss-test-infra#2302
Checklist: