Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Added Kubernetes 1.30 and 1.31 to other tests #11463

Merged
merged 1 commit into from
Dec 13, 2024
Merged

chore: Added Kubernetes 1.30 and 1.31 to other tests #11463

merged 1 commit into from
Dec 13, 2024

Conversation

hbelmiro
Copy link
Contributor

For some reason, my IDE didn't find all the occurrences of .github/actions/kfp-cluster when I sent #11450.

This PR is a follow-up of #11450.

Checklist:

@google-oss-prow Google OSS Prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Dec 12, 2024
@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Dec 13, 2024
@hbelmiro hbelmiro marked this pull request as ready for review December 13, 2024 10:46
@google-oss-prow google-oss-prow bot requested a review from zijianjoy December 13, 2024 10:46
@hbelmiro
Copy link
Contributor Author

@DharmitD can you PTAL?

cc @mprahl

DharmitD
DharmitD reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that a version matrix is added to all the occurrences of .github/actions/kfp-cluster

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 13, 2024
DharmitD
DharmitD approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit cb07619 into kubeflow:master Dec 13, 2024
12 checks passed
@hbelmiro hbelmiro deleted the fix-action-calls branch December 13, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD approved these changes

@ouadakarim ouadakarim Awaiting requested review from ouadakarim

@rimolive rimolive Awaiting requested review from rimolive

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@DharmitD DharmitD

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbelmiro @DharmitD