feat: Introduce cache_key to sdk #11466
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @zzmao. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
zzmao
force-pushed
the
cache
branch
2 times, most recently
from
3f1882b to
2a72f12
Compare
Signed-off-by: Ze Mao <[email protected]>
| @@ -709,6 +710,8 @@ def run_pipeline( | |||
| is ``True`` for all tasks by default. If set, the | |||
| setting applies to all tasks in the pipeline (overrides the | |||
| compile time settings). | |||
| cache_key (optional): Customized cache key for this task. | |||
| If set, the cache_key will be used as the key for the task's cache. | |||
There was a problem hiding this comment.
Could you elaborate on why we would need a cache key? This doc string isn't providing a clear enough idea.
I would suggest adding some description to the PR, and also linking the related GitHub issue.
There was a problem hiding this comment.
Thanks for reviewing!
This is for Issue #11328
Doc: https://docs.google.com/document/d/1oNgYyFYondaVSFf9Pd3Q9uVzaqBr5wrOMHKgX9MMa78/edit?tab=t.0
(Also updated this information in description)
|
/retest |
|
/retest |
|
@zzmao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| @@ -686,6 +686,7 @@ def run_pipeline( | |||
| version_id: Optional[str] = None, | |||
| pipeline_root: Optional[str] = None, | |||
| enable_caching: Optional[bool] = None, | |||
| cache_key: Optional[str] = '', | |||
There was a problem hiding this comment.
nit: default to None, and set the proto field only when it's not None
Description of your changes:
Introduce cache_key to SDK for issue #11328
Doc: https://docs.google.com/document/d/1oNgYyFYondaVSFf9Pd3Q9uVzaqBr5wrOMHKgX9MMa78/edit?tab=t.0
Checklist: