Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixes SDK tests #11488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Dec 26, 2024

SDK Tests have been broken since December 18th.

https://github.com/kubeflow/pipelines/actions/runs/12399881929/job/34615777065

This PR fixes that.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow google-oss-prow bot added size/XS and removed size/L labels Dec 26, 2024
@hbelmiro hbelmiro marked this pull request as ready for review December 26, 2024 15:12
@google-oss-prow google-oss-prow bot requested a review from jlyaoyuli December 26, 2024 15:13
@hbelmiro hbelmiro changed the title Fix sdk tests chore(tests): fix SDK tests Dec 26, 2024
@hbelmiro hbelmiro changed the title chore(tests): fix SDK tests chore(tests): fixes SDK tests Dec 26, 2024
Signed-off-by: Helber Belmiro <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hbelmiro. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor Author

@DharmitD @HumairAK can one of you guys PTAL?

@hbelmiro hbelmiro changed the title chore(tests): fixes SDK tests test: fixes SDK tests Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant