Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Detailed information of nodes is not displayed when clicking the node. Fixes #11325 #11493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ElayAharoni
Copy link
Contributor

Fixes #11325.

i changed the selection functions that are passed to DagCanvas and ReactFlow.

this is the behavior after the fix:

https://www.loom.com/share/713c1ec886e24550a1746784e4e347fe?sid=25ead37a-db5c-4f74-a334-205e2d453981

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ElayAharoni ElayAharoni force-pushed the Detailed-information-of-nodes-is-not-displayed-when-clicking-the-node-consecutively-#11325 branch from a8f74c8 to 19dcddc Compare December 31, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend] Detailed information of nodes is not displayed when clicking the node consecutively
1 participant