Draft: fix the minResources calculation logic of podgroup for volcano #2262
+258
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
As described in #2244, the spark.dynamicAllocation.* & spark.kubernetes.memoryOverheadFactor params of spark are not taken into account when calculating memory of minResources for volcano podGroup, so i created this PR and see if that helps. And then we can consider extracting
resourceusage
module to thescheduler
directory.Note that only
cluster deploy mode
is considered in this PR, afterresourceusage
module is extracted, i can importresourceusage
module in volcano package and fix the minResources calculation logic in bothcluster deploy mode
andclient deploy mode
.