Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add repo links and star counts to distributions #3598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Oct 3, 2023

Currently, the list of kubeflow distributions is overwhelming for new users.

This PR adds a small "GitHub Star Count" below each distribution's website link, which should help users make informed decisions about which distributions to test.

The star count is generated automatically by the widely used https://shields.io/ site, which is already used all over the Kubeflow org README's.

Screenshot

Screenshot 2023-10-03 at 12 43 54

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thesuperzapper
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from alfsuse and pdmack October 3, 2023 19:42
@thesuperzapper
Copy link
Member Author

@jbottum @james-jwu @zijianjoy I am interested in your feedback about this PR, it adds the "GitHub Star Count" of each distribution to our "Installing Kubeflow" page.

This change is small, but will massively improve the new-user experience when searching for a distribution.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 5, 2023
@Arhell Arhell removed their assignment Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants