-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: #3717 #3720
base: master
Are you sure you want to change the base?
Fixes: #3717 #3720
Conversation
https://github.com/kubeflow/katib/blob/2d308b72c3b4ed6f1365d7c6002a307386a8d252/pkg/db/v1beta1/common/const.go#L43 On this line parse another env. KATIB_POSTGRESQL_DATABASE - not implemented. I'll check releases branches -> current main. All time was KATIB_POSTGRESQL_DB_DATABASE kubeflow#3717
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kaeldara-ru The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Kaeldara-ru. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@Kaeldara-ru can you please edit the PR's description where you set the issue number with the following?
Fixes https://github.com/kubeflow/website/issues/3717
That way GitHub automatically binds this PR to the issue and closes the issue when the PR is closed.
Also, can you please sign off your commits?
@Kaeldara-ru Thank you for your contribution 🎉 I think, you should add this: Fixes: #3717 to your PR description as @hbelmiro suggested. |
@Kaeldara-ru Please can you sign your commit as described here: https://www.kubeflow.org/docs/about/contributing/#sign-off-your-commits? |
PR still valid. I'm following up on this. @Kaeldara-ru let us know if you need any help. |
https://github.com/kubeflow/katib/blob/2d308b72c3b4ed6f1365d7c6002a307386a8d252/pkg/db/v1beta1/common/const.go#L43
On this line parse another env. KATIB_POSTGRESQL_DATABASE - not implemented. I'll check releases branches -> current main. All time was KATIB_POSTGRESQL_DB_DATABASE
Fixes: #3717