Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kkp-management via argocd tutorial #1723

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dharapvj
Copy link
Contributor

Step by step tutorial to explain how to use ArgoCD for Gitops based management of KKP master and seed.

@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Jul 31, 2024
@dharapvj
Copy link
Contributor Author

CC @toschneck

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 31, 2024
@dharapvj
Copy link
Contributor Author

/assign toschneck

@scheeles
Copy link
Member

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2024
@dharapvj dharapvj changed the title Added argocd-kkp-managemet tutorial Added kkp-management via argocd tutorial Sep 13, 2024
@dharapvj
Copy link
Contributor Author

@scheeles - I have addressed your review comments. Please check once more.

@xrstf
Copy link
Contributor

xrstf commented Oct 21, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5802a21870f1512fd56b4b370893e3c03acdf0c5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@kubermatic-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@moadqassem
Copy link
Member

/hold

This same folder structure can be further expanded to add kubeone installations for additional environments like staging and prod.

### Note about URLs:
The [demo codebase](https://github.com/dharapvj/kkp-using-argocds) assumes `argodemo.lab.kubermatic.io` as base URL for KKP. KKP Dashboard is available at this URL. So master argocd, all master tools like prometheus, grafana, etc are accessible at `*.argodemo.lab.kubermatic.io`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should this repo be moved?
  • The KKP dashboard
  • "So master argocd"?
  • Prometheus, Grafana capitalized

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this repo be moved?

I also would like it to be under Kubermatic umbrella. Lets talk about where can we place it an I would be happy to move.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot judge this. If @moadqassem had no complaints, then we can keep it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants