EKS authentication based on AWS Sigv4 #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
yue9944882
force-pushed
the
eks-authentication
branch
from
5cc581b to
fda7628
Compare
Signed-off-by: Min Jin <[email protected]>
yue9944882
force-pushed
the
eks-authentication
branch
from
fda7628 to
a51debb
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This authentication class helps connecting to an EKS cluster w/o requiring having "aws" cli in the $PATH. Before this CR, users can still talk to EKS cluster by using the exec plugin, but now the new
EKSAuthenticationclass will help them get rid of that CLI dependency. EKS cluster uses a bearer token which is signed by AWS AK/SK using SIGv4 in a customized format.(I think this is the first implementation of EKS bearer token generator in Java, the authentication protocol is never documented anywhere :/)