Regenerate for Kubernetes 1.31 #3734
Conversation
|
|
k8s-ci-robot
added
the
cncf-cla: no
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| public static GsonBuilder createGson() { | ||
| GsonFireBuilder fireBuilder = new GsonFireBuilder() | ||
| ; | ||
| - GsonBuilder builder = fireBuilder.createGsonBuilder(); | ||
| - return builder; | ||
| + GsonBuilder builder = | ||
| + fireBuilder | ||
| + .registerPreProcessor(V1Status.class, new V1StatusPreProcessor()) |
There was a problem hiding this comment.
@brendandburns looks like the patch has been broken for a while, curiously did you change JSON.java manually when generating 1.30?
There was a problem hiding this comment.
Yeah, I think I broke this when I regenerated 1.30
|
/lgtm @brendandburns the change LGTM, could you squash the change into single commit to workaround the CLA check? it's a bit tricky that we can't do a normal squash, instead we need to do a force reset and re-commit to purge the bot author information from the commit. |
k8s-ci-robot
added
the
lgtm
|
Can I humbly ask for the models to be regenerated again so that there are swagger annotations as well? Alternatively, regenerate them again after this merge, but before the release of 22.x.y? Thank you very much in advance. |
|
@cache-sk its going to take some work to regenerate with the annotations, I'm going to merge this PR. Then we'll see if I have time to run the regeneration before we cut the release. We will definitely get it into a patch release for 22.0.x |
brendandburns
force-pushed
the
automated-generate-4e0fa759
branch
from
7e7dc60 to
121d0ea
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
added
cncf-cla: yes
|
@yue9944882 squashed, it needs a new lgtm since the commits changed. |
yue9944882
added
the
lgtm
@yue9944882 I had to generate this in my own branch, and then it turned out the patches were a little broken, so fixed up the JSON.java patch also. Let me know if you want me to split out that fix into a different branch.