-
Notifications
You must be signed in to change notification settings - Fork 538
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: allow to set the cwd in
copyFromPod
for use in tar
- Loading branch information
1 parent
998e631
commit 2bb4ab7
Showing
1 changed file
with
8 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bb4ab7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SayakMukhopadhyay Hi, do you know if there is a reason this commit has not yet been included in a published package on NPM? Thanks!
2bb4ab7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leahjlou Nope, I am just an independent contributor. The maintainers would be able to provide info on when a new package will be published. But I have another PR #988 that I want to get merged but I am having trouble getting tests to pass. I believe there is another PR #991 that was approved but not yet merged due to some changes made after the approval. Its possible that the maintainers want these 2 PRs to be done (or at least #991) before publishing
2bb4ab7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SayakMukhopadhyay thanks for the response (and your contributions). I've tagged a maintainer in another comment and will keep an eye out. If something is blocking a release that I can help with in any way, I'd be happy to jump in.
2bb4ab7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the tests are not passing in #991 because some of our dependencies have critical problems. Looking to fix now.
2bb4ab7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sorry, just revisited this. This is into master. My 991 PR is into the release 1.x branch. FYI.