Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Fix reconciliation logic for existing and deleted objects #139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kvaps
Copy link

@kvaps kvaps commented Jul 31, 2024

This PR addresses two cases:

  • Controller Restarts:
    When the controller restarts, it does not handle deletions for removed objects.
    Specifically, when an object with a deletion timestamp is passed into the Add() method, the deletion process was not handled correctly.

  • Recreation of Objects:
    The recreation of objects is not functioning as expected. For example, when an object is created, deleted, and then created again.
    In this scenario, the object may enter the Update method, where the creation process was not being handled properly.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2024
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali July 31, 2024 18:53
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kvaps
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from xing-yang July 31, 2024 18:53
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 31, 2024
@kvaps
Copy link
Author

kvaps commented Aug 1, 2024

/assign @saad-ali

@kvaps
Copy link
Author

kvaps commented Aug 1, 2024

/assign @shanduur

@shanduur
Copy link
Contributor

shanduur commented Aug 1, 2024

Hi! Thank you for your pull request. We are in the process of migration towards the monorepo, thus we will no longer accept any PRs to this repository. Please submit your changes to the https://github.com/kubernetes-sigs/container-object-storage-interface-api/tree/monorepo . Thanks!

@kvaps
Copy link
Author

kvaps commented Aug 1, 2024

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants