-
Notifications
You must be signed in to change notification settings - Fork 30
Fix reconciliation logic for existing and deleted objects #139
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrei Kvapil <[email protected]>
Signed-off-by: Andrei Kvapil <[email protected]>
Signed-off-by: Andrei Kvapil <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kvaps The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @saad-ali |
/assign @shanduur |
Hi! Thank you for your pull request. We are in the process of migration towards the monorepo, thus we will no longer accept any PRs to this repository. Please submit your changes to the https://github.com/kubernetes-sigs/container-object-storage-interface-api/tree/monorepo . Thanks! |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
This PR addresses two cases:
Controller Restarts:
When the controller restarts, it does not handle deletions for removed objects.
Specifically, when an object with a deletion timestamp is passed into the Add() method, the deletion process was not handled correctly.
Recreation of Objects:
The recreation of objects is not functioning as expected. For example, when an object is created, deleted, and then created again.
In this scenario, the object may enter the Update method, where the creation process was not being handled properly.