Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for format options #1769

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add e2e tests for format options #1769

merged 1 commit into from
Oct 6, 2023

Conversation

AndrewSirenko
Copy link
Contributor

Is this a bug fix or adding new feature?
feature

What is this PR about? / Why do we need it?
Adds end to end tests for format option parameters like blocksize and bytesperinode

What testing is done?
ginkgo run --focus="[format]"

@AndrewSirenko AndrewSirenko requested a review from torredil October 4, 2023 13:08
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from ConnorJC3 October 4, 2023 13:08
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 4, 2023
@AndrewSirenko AndrewSirenko force-pushed the formattingOptionE2eTestsSimpler branch from f978ff4 to b52144b Compare October 4, 2023 13:12
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Code Coverage Diff

This PR does not change the code coverage

torredil
torredil reviewed Oct 4, 2023
View reviewed changes
tests/e2e/testsuites/dynamically_provisioned_resize_volume_tester.go Show resolved Hide resolved
tests/e2e/testsuites/format_options_tester.go Outdated Show resolved Hide resolved
tests/e2e/testsuites/format_options_tester.go Outdated Show resolved Hide resolved
tests/e2e/format_options.go Outdated Show resolved Hide resolved
tests/e2e/testsuites/format_options_tester.go Outdated Show resolved Hide resolved
@AndrewSirenko AndrewSirenko force-pushed the formattingOptionE2eTestsSimpler branch from b52144b to 817b769 Compare October 4, 2023 15:55
@AndrewSirenko AndrewSirenko marked this pull request as ready for review October 4, 2023 15:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from torredil October 4, 2023 15:55
ConnorJC3
ConnorJC3 requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half the PR seems to be missing, namely the part where we check if the filesystem was actually formatted correctly

tests/e2e/format_options.go Outdated Show resolved Hide resolved
tests/e2e/testsuites/format_options_tester.go Outdated Show resolved Hide resolved
@AndrewSirenko AndrewSirenko force-pushed the formattingOptionE2eTestsSimpler branch from 817b769 to 7542fb5 Compare October 5, 2023 19:38
@AndrewSirenko
Copy link
Contributor Author

AndrewSirenko commented Oct 5, 2023 •
edited
Loading

As discussed with @ConnorJC3 @torredil we will validate that custom formatting options were actually applied by mkfs via privileged ubuntu containers running the tune2fs command and regex-Finding their logs in a future PR once testsuite utils are refactored.

See #1763 for that approach.

A rejected alternative was adding an e2e test confirming that the pod fails to get created when an invalid format option was provided.

@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2023
@AndrewSirenko AndrewSirenko force-pushed the formattingOptionE2eTestsSimpler branch from 7542fb5 to 81acc24 Compare October 6, 2023 13:03
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@torredil
Copy link
Member

torredil commented Oct 6, 2023

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@torredil torredil added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7ca4149 into kubernetes-sigs:master Oct 6, 2023
6 checks passed
@AndrewSirenko AndrewSirenko deleted the formattingOptionE2eTestsSimpler branch November 1, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil Awaiting requested review from torredil

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

Assignees

@ConnorJC3 ConnorJC3

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewSirenko @k8s-ci-robot @ConnorJC3 @torredil