Supporting String Interpolation for Modifying Tags On Existing Volumes Through VAC

[mdzraf]

Is this a bug fix or adding new feature?

New feature

What is this PR about? / Why do we need it?

This will add the support for runtime string interpolation on tag values for a volume upon modification, which allows for customers to specify placeholder values for the PVC namespace, PVC name and PV name, which will then be dynamically computed at runtime.

What testing is done?

Unit tests were ran to ensure that input was parsed properly and manual testing was done after initial changes to external-resizer sidecar code were made to pass in the extra metadata necessary to the driver and ensuring that these tags were properly added at runtime.

[k8s-ci-robot]

Hi @mdzraf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ConnorJC3]

/ok-to-test

[github-actions]

Code Coverage Diff

File	Old Coverage	New Coverage	Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/controller_modify_volume.go	78.3%	79.8%	1.5

[mdzraf]

/hold

[mdzraf]

/retest

[mdzraf]

/retest

[AndrewSirenko]

/lgtm

[torredil]

/lgtm

[ConnorJC3]

lgtm other than squash

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andrewsirenko. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mdzraf]

/retest

[mdzraf]

/retest

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

@mdzraf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows	0d0d9ff	link	true	/test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows
pull-aws-ebs-csi-driver-test-helm-chart	0d0d9ff	link	true	/test pull-aws-ebs-csi-driver-test-helm-chart
pull-aws-ebs-csi-driver-e2e-multi-az	0d0d9ff	link	true	/test pull-aws-ebs-csi-driver-e2e-multi-az
pull-aws-ebs-csi-driver-external-test	0d0d9ff	link	true	/test pull-aws-ebs-csi-driver-external-test
pull-aws-ebs-csi-driver-external-test-eks	0d0d9ff	link	true	/test pull-aws-ebs-csi-driver-external-test-eks
pull-aws-ebs-csi-driver-e2e-single-az	0d0d9ff	link	true	/test pull-aws-ebs-csi-driver-e2e-single-az
pull-aws-ebs-csi-driver-unit	0d0d9ff	link	true	/test pull-aws-ebs-csi-driver-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.