Selinux Mount Option #2253
Merged
Selinux Mount Option #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Code Coverage DiffThis PR does not change the code coverage |
|
flake (kops failed to create cluster) /retest |
|
/retest lots of flakes today |
ConnorJC3
force-pushed
the
selinux-mounts
branch
from
2acf2f6 to
32f6bda
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Connor Catlett <[email protected]>
ConnorJC3
force-pushed
the
selinux-mounts
branch
from
32f6bda to
2eefc58
Compare
|
/retest |
ElijahQuinones
approved these changes
Dec 19, 2024
k8s-ci-robot
added
the
lgtm
AndrewSirenko
approved these changes
Dec 19, 2024
k8s-ci-robot
added
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
Adds a new helm parameter,
node.selinux, that mounts the relevant directories to allow the selinux-awaremountbinary to perform selinux-specific optimizations. (This parameter can also be used in the future for any other selinux optimizations on the node).This must be a parameter that is default-disabled, because
/sys/fs/selinuxwill not exist unless SELinux is actually enabled on the nodes.How was this change tested?
CI/Manually
Does this PR introduce a user-facing change?