-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics.md to included quick start for node.enableMetrics #2268
Conversation
Welcome @cam634! |
Hi @cam634. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Don't worry about the test failures. We're seeing an increase in e2e test flakes, likely due to Kubernetes community releasing K8s 1.32 related components at the moment. |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Code Coverage DiffThis PR does not change the code coverage |
What type of PR is this?
/kind documentation
What is this PR about? / Why do we need it?
This pr adds documentation that seems to be missing for node.enableMetrics figured this would be important given the metric endpoints are on different ports
How was this change tested?
No test needed docs
Does this PR introduce a user-facing change?
NONE