Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo controlled build go version #639

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Repo controlled build go version #639

merged 4 commits into from
Jan 30, 2024

Conversation

xdu31
Copy link
Contributor

@xdu31 xdu31 commented Nov 11, 2023

What this PR does / why we need it:

Follow KEP-3744 to make aws-iam-authenticator to stay on supported Go versions.

This PR follows kubernetes/kubernetes#114660 and kubernetes/kubernetes#115377 for repo-controlled go version to use in CI.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 11, 2023
@xdu31 xdu31 force-pushed the go-support-master branch 2 times, most recently from 21a406e to d55f440 Compare November 11, 2023 15:24
@xdu31 xdu31 changed the title Repo controlled build go version [DON'T MERGE] Repo controlled build go version Nov 11, 2023
@xdu31
Copy link
Contributor Author

xdu31 commented Nov 11, 2023

/retest

1 similar comment
@xdu31
Copy link
Contributor Author

xdu31 commented Nov 11, 2023

/retest

micahhausler
micahhausler reviewed Nov 13, 2023
View reviewed changes
.github/workflows/deps.yml Outdated
@@ -19,18 +19,3 @@ jobs:
uses: actions/checkout@v4
with:
show-progress: false
- id: govulncheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove govunlcheck?

Copy link
Contributor Author

@xdu31 xdu31 Nov 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove govunlcheck?

Hi @micahhausler I need to remove it temporarily to make the premerge test move forward, I will add it back when your PR #638 to resolve the govunlcheck is merged.

That's why it is marked as DON'T MERGE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @micahhausler I have rebased the PR with go 1.21.5 version and added back the govunlcheck, could you take another look?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@xdu31 xdu31 force-pushed the go-support-master branch from f5891ba to 5b56ac6 Compare January 2, 2024 05:15
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2024
@xdu31 xdu31 force-pushed the go-support-master branch from 5b56ac6 to 30353e6 Compare January 2, 2024 05:18
@xdu31 xdu31 changed the title [DON'T MERGE] Repo controlled build go version Repo controlled build go version Jan 2, 2024
@xdu31 xdu31 requested a review from micahhausler January 2, 2024 05:19
@xdu31
Copy link
Contributor Author

xdu31 commented Jan 2, 2024

/retest

@xdu31 xdu31 force-pushed the go-support-master branch from 30353e6 to bc002e7 Compare January 28, 2024 16:30
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 28, 2024
@nnmin-aws
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyotimahapatra, xdu31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit c5d32fe into kubernetes-sigs:master Jan 30, 2024
8 checks passed
This was referenced Feb 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyotimahapatra jyotimahapatra jyotimahapatra approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees

@nnmin-aws nnmin-aws

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xdu31 @nnmin-aws @k8s-ci-robot @micahhausler @jyotimahapatra