Cherry-pick: Update go to 1.21.4 (#648) #659
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
@nckturner: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -12,7 +12,7 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| ARG image=public.ecr.aws/eks-distro-build-tooling/eks-distro-minimal-base-nonroot:2023-02-22-1677092456.2 | |||
| ARG golang_image=public.ecr.aws/eks-distro-build-tooling/golang:1.19-gcc | |||
| ARG golang_image=public.ecr.aws/docker/library/golang:1.21.4 | |||
There was a problem hiding this comment.
Same as #658, happy to switch if AWS builds override this
There was a problem hiding this comment.
Yeah this was changed by @dims in master, asked for his perspective on it and will update this PR if necessary.
There was a problem hiding this comment.
Probably makes sense to leave the build image alone in the release branches
There was a problem hiding this comment.
Discussed with @dims and we will inject the eks-distro image internally and this repo will reference the docker/library/golang:1.21.4 image, so long as it doesn't effect the authenticator behavior in any way (it shouldn't).
Cherry pick of #648
What this PR does / why we need it:
Update go to v1.21.4