Fix credential expirability check #777
Conversation
|
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @kanwren! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kanwren The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @kanwren. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
kanwren
force-pushed
the
kanwren/fix-credential-caching-error
branch
from
e135dc2 to
1502060
Compare
Fixes a bug introduced during the refactor in e92213c, which incorrectly inverted the previous credential expirability checking logic. This caused errors about being unable to cache otherwise cachable credentials. Also changes the error log around the previous expirability check site to no longer log the error that previously came from the `ExpiresAt()` check; since this is now the wrong `err`, it's always `nil`. Addresses kubernetes-sigs#776
kanwren
force-pushed
the
kanwren/fix-credential-caching-error
branch
from
1502060 to
17498b2
Compare
| @@ -251,7 +251,7 @@ func (f *FileCacheProvider) RetrieveWithContext(ctx context.Context) (credential | |||
| } | |||
| } else { | |||
| // credential doesn't support expiration time, so can't cache, but still return the credential | |||
| _, _ = fmt.Fprintf(os.Stderr, "Unable to cache credential: %v\n", err) | |||
| _, _ = fmt.Fprint(os.Stderr, "Unable to cache credential: credential doesn't support expiration\n") | |||
| err = nil | |||
There was a problem hiding this comment.
Can you remove this line as its a no-op now to not cause any confusion
|
@kanwren can you fix this also
|
Fixes a bug introduced during the refactor in e92213c, which incorrectly inverted the previous credential expirability checking logic. This caused errors about being unable to cache otherwise cachable credentials. Also changes the error log around the previous expirability check site to no longer log the error that previously came from the
ExpiresAt()check; since this is now the wrongerr, it's alwaysnil.Addresses #776