Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.20] fix: flag panic if a flag is defined after being set #1052

Closed
wants to merge 1 commit into from
Closed

[release-1.20] fix: flag panic if a flag is defined after being set #1052

wants to merge 1 commit into from

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #997

/assign andyzhangx

fix: flag panic if a flag is defined after being set

@cvvz
Squashed commit of the following:
93f96b8 
commit e405f76
Author: weizhichen <[email protected]>
Date:   Thu Aug 24 09:35:14 2023 +0000

    fix

commit de03fda
Author: weizhichen <[email protected]>
Date:   Thu Aug 24 09:33:26 2023 +0000

    fix

commit 2389047
Author: weizhichen <[email protected]>
Date:   Thu Aug 24 08:20:30 2023 +0000

    fix

commit 3834b62
Author: weizhichen <[email protected]>
Date:   Thu Aug 24 08:11:12 2023 +0000

    fix log panic
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 15, 2023
Merged
4 tasks
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign andyzhangx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 15, 2023
@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-blob-csi-driver-verify 93f96b8 link true /test pull-blob-csi-driver-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @andyzhangx @cvvz