Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: bumps ci versions to more recent versions #5118

Merged
merged 1 commit into from
Sep 9, 2024
Merged

🐛 fix: bumps ci versions to more recent versions #5118

merged 1 commit into from
Sep 9, 2024

Conversation

faiq
Copy link
Contributor

@faiq faiq commented Sep 6, 2024 •
edited
Loading

What type of PR is this?:

I observed some tests try to pull in AMIs that are not available according to this https://cluster-api-aws.sigs.k8s.io/topics/images/built-amis

it bumps them up to 1.27.0 and beyond.

/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2024
@k8s-ci-robot k8s-ci-robot requested review from nrb and vincepri September 6, 2024 19:16
@k8s-ci-robot k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 6, 2024
@faiq
Copy link
Contributor Author

faiq commented Sep 6, 2024

this is the error i was seeing in another PR

status:
  conditions:
  - lastTransitionTime: "2024-09-06T00:04:26Z"
    message: 0 of 3 completed
    reason: InstanceProvisionFailed
    severity: Error
    status: "False"
    type: Ready
  - lastTransitionTime: "2024-09-06T00:04:26Z"
    message: 'failed to create AWSMachine instance: failed to find ami: found no AMIs
      with the name: "capa-ami-ubuntu-18.04-?1.25.0-*"'
    reason: InstanceProvisionFailed
    severity: Error
    status: "False"
    type: InstanceReady

@faiq faiq force-pushed the faiq/bump-versions branch from 95e73c2 to eeddba1 Compare September 6, 2024 19:52
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2024
@faiq
Copy link
Contributor Author

faiq commented Sep 6, 2024

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@faiq
Copy link
Contributor Author

faiq commented Sep 6, 2024

/test pull-cluster-api-provider-aws-e2e

@faiq
Copy link
Contributor Author

faiq commented Sep 6, 2024

/retest

1 similar comment
@faiq
Copy link
Contributor Author

faiq commented Sep 6, 2024

/retest

@faiq
Copy link
Contributor Author

faiq commented Sep 6, 2024

these are failing on cloud formation steps :(

@faiq
Copy link
Contributor Author

faiq commented Sep 6, 2024

this failed on deleting the cluster https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/5118/pull-cluster-api-provider-aws-e2e/1832165220013838336#1:build-log.txt%3A3064

looks like a flake to me tbh

@nrb
Copy link
Contributor

nrb commented Sep 7, 2024

/retest

2 similar comments
@faiq
Copy link
Contributor Author

faiq commented Sep 7, 2024

/retest

@faiq
Copy link
Contributor Author

faiq commented Sep 7, 2024

/retest

@AndiDog
Copy link
Contributor

AndiDog commented Sep 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2024
@nrb
Copy link
Contributor

nrb commented Sep 9, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 686a3f5 into kubernetes-sigs:main Sep 9, 2024
21 checks passed
@mtulio mtulio mentioned this pull request Sep 9, 2024
Merged
5 tasks
@faiq faiq mentioned this pull request Sep 9, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb Awaiting requested review from nrb

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@AndiDog AndiDog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faiq @nrb @AndiDog @k8s-ci-robot