Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make internal LB private IP configurable #5269

Closed

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Nov 13, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5264

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

make Internal LB private configurable

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nawazkh. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.81%. Comparing base (ec18b58) to head (5b36afb).

Files with missing lines Patch % Lines
api/v1beta1/azurecluster_default.go 76.47% 3 Missing and 1 partial ⚠️
api/v1beta1/azurecluster_validation.go 94.44% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5269      +/-   ##
==========================================
+ Coverage   52.78%   52.81%   +0.03%     
==========================================
  Files         270      270              
  Lines       29057    29084      +27     
==========================================
+ Hits        15337    15360      +23     
- Misses      12928    12931       +3     
- Partials      792      793       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nawazkh nawazkh force-pushed the make_private_lb_ip_configurable branch from 196dc2d to 5b36afb Compare November 13, 2024 08:53
@k8s-ci-robot
Copy link
Contributor

@nawazkh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-verify 5b36afb link true /test pull-cluster-api-provider-azure-verify
pull-cluster-api-provider-azure-e2e 5b36afb link true /test pull-cluster-api-provider-azure-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

- update default template
- update aad templates
- update cluster.go to add private IP of the ILB
@nawazkh nawazkh force-pushed the make_private_lb_ip_configurable branch from e9b5cdb to 0f5027f Compare November 13, 2024 10:01
@nawazkh
Copy link
Member Author

nawazkh commented Nov 13, 2024

/close since I can only test this with #5248

@nawazkh
Copy link
Member Author

nawazkh commented Nov 13, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@nawazkh: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nawazkh
Copy link
Member Author

nawazkh commented Nov 13, 2024

/reopen

@k8s-ci-robot
Copy link
Contributor

@nawazkh: Failed to re-open PR: state cannot be changed. The make_private_lb_ip_configurable branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make internal LB IP configurable
2 participants