-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make internal LB private IP configurable #5269
make internal LB private IP configurable #5269
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5269 +/- ##
==========================================
+ Coverage 52.78% 52.81% +0.03%
==========================================
Files 270 270
Lines 29057 29084 +27
==========================================
+ Hits 15337 15360 +23
- Misses 12928 12931 +3
- Partials 792 793 +1 ☔ View full report in Codecov by Sentry. |
196dc2d
to
5b36afb
Compare
@nawazkh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- update default template - update aad templates - update cluster.go to add private IP of the ILB
e9b5cdb
to
0f5027f
Compare
/close since I can only test this with #5248 |
/close |
@nawazkh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@nawazkh: Failed to re-open PR: state cannot be changed. The make_private_lb_ip_configurable branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5264
Special notes for your reviewer:
TODOs:
Release note: