-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added yamllint config file .yamllint, fixed current linting errors, added install and run yamllint targets. #1727
Conversation
…dded install and run yamllint targets.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yuanning6 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @yuanning6. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
Hi @Prajyot-Parab ! Thank you so much for your time to take a look at my code! Please let me know if any adjustment is needed! |
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, A quick query other than that overall LGTM.
Also I see you have previous PR: #1521, Its advised to update the same PR with latest change but I could see you are hitting some issue and I hope you tried to resolve it before raising this.
If not required close the no more needed PR out of these 2.
|
||
.PHONY: install-yamllint | ||
install-yamllint: ## Install yamllint if not present | ||
@which yamllint > /dev/null || (echo "Installing yamllint..." && pip install --user yamllint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the guarantee that the pip will be available, aren't there any alternative to download this other than pip install, may be via go?
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Don't see any activities in this PR, @Amulyam24 will pick this PR and review comments and create a new one |
What this PR does / why we need it:
This PR adds a .yamllint config file which has rules to config yamllint to enhance linting for yaml files. The lint will be helpful to avoid issues like 7cd7fcc.
Fixed current yamllint errors.
Added install and run yamllint targerts in Makefile.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1497
Special notes for your reviewer:
/area provider/ibmcloud
Release note: