Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yamllint enhancement #2072

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Yamllint enhancement #2072

wants to merge 4 commits into from

Conversation

priyanshikhetwani
Copy link

@priyanshikhetwani priyanshikhetwani commented Nov 26, 2024 •
edited
Loading

What this PR does / why we need it: Enhance linting to cover yaml files (to avoid issues as - 7cd7fcc)

Fixes #1497

Test Workflow:

Screenshot 2024-11-27 at 1 49 52 AM

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: priyanshikhetwani
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @priyanshikhetwani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit ecc3b86
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67495ca920f2a80008715041
😎 Deploy Preview https://deploy-preview-2072--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@priyanshikhetwani priyanshikhetwani mentioned this pull request Nov 27, 2024
Closed
@priyanshikhetwani priyanshikhetwani changed the title WIP: Yamllint enhancement Yamllint enhancement Nov 28, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2024
@priyanshikhetwani priyanshikhetwani changed the title Yamllint enhancement WIP: Yamllint enhancement Nov 29, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2024
@priyanshikhetwani priyanshikhetwani changed the title WIP: Yamllint enhancement Yamllint enhancement Nov 29, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2024
@mkumatag
Copy link
Member

mkumatag commented Dec 3, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2024
@Amulyam24
Copy link
Contributor

Hi @priyanshikhetwani, I see that 2 PRs are open for yamllint, can you please close one which is not needed anymore?

@priyanshikhetwani
Copy link
Author

Hi @priyanshikhetwani, I see that 2 PRs are open for yamllint, can you please close one which is not needed anymore?

Closed 2013

@Amulyam24
Copy link
Contributor

/retest

1 similar comment
@priyanshikhetwani
Copy link
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amulyam24 Amulyam24 Awaiting requested review from Amulyam24

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance linting to cover yaml files
5 participants
@priyanshikhetwani @k8s-ci-robot @mkumatag @Amulyam24 @yuanning6