Fix warnings in kustomization file

[priyanshikhetwani]

What this PR does / why we need it: Fix Warnings in Kustomization file

make release

# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Description:

1. Replace bases with resources
   Diff:
   bases (deprecated): This field was used to reference other directories or resources (e.g., CRDs, namespaces, etc.) as "bases" from which resources would be pulled.
   resources (recommended): The resources field is now used to include external files or resources directly. Kustomize now uses resources instead of bases for the same purpose.
   Migration Approach:
   Replacing the bases field with resources, using the same paths.
   Before:

bases:
  - ../crd
  - ../rbac

After:

resources:
  - ../crd
  - ../rbac

2. Replace commonLabels with labels
   Diff:
   commonLabels (deprecated): The commonLabels field was used to apply common labels to all resources within the kustomization.
   labels (recommended): The labels field now serves the same purpose as commonLabels, but with more flexibility and consistent behavior.
   Migration Approach:
   Replacing the commonLabels field with labels, ensuring that the structure matches the new format for labels.
   Before:

commonLabels:
  cluster.x-k8s.io/v1beta1: v1beta1_v1beta2

After:

labels:
  cluster.x-k8s.io/v1beta1: v1beta1_v1beta2

3. Replace patchesStrategicMerge with patches
   Diff:
   patchesStrategicMerge (deprecated): This field was used to apply strategic merge patches to the resources defined in the Kustomization.
   patches (recommended): The patches field is now used to apply patches (both strategic and JSON patch) to resources. The main difference is that patches supports both strategicMerge and jsonPatch types.
   Migration Approach:
   Replacing the patchesStrategicMerge field with the patches field. The structure of the patches will stay mostly the same, but now it supports a wider variety of patch types.

Before:

[patchesStrategicMerge:

• patches/webhook_in_ibmvpcclusters.yaml

After:

patches:
  - path: patches/webhook_in_ibmvpcclusters.yaml

4. Replace vars with replacements
   Diff:
   vars (deprecated): The vars field was used to define variables that could be used for substitution throughout the Kustomization file.
   replacements (recommended): The replacements field provides a more explicit way to define variable substitutions. It allows you to specify where the values are coming from (source) and where they should be applied (target).
   Migration Approach:
   For each variable defined in vars, create a replacements entry. This involves specifying the source field and the target field for the substitution.

Before:

vars:
- name: SERVICE_NAMESPACE # namespace of the service
  objref:
    kind: Service
    version: v1
    name: webhook-service
  fieldref:
    fieldpath: metadata.namespace
- name: SERVICE_NAME
  objref:
    kind: Service
    version: v1
    name: webhook-service

After:

replacements:
- source:
    fieldPath: metadata.name
    kind: Service
    name: webhook-service
  targets:
  - fieldPaths:
    - spec.dnsNames.0
    - spec.dnsNames.1
    options:
      delimiter: .
    select:
      kind: Certificate
      name: serving-cert
- source:
    fieldPath: metadata.namespace
    kind: Service
    name: webhook-service
  targets:
  - fieldPaths:
    - spec.dnsNames.0
    - spec.dnsNames.1
    options:
      delimiter: .
      index: 1
    select:
      kind: Certificate
      name: serving-cert

Test:

kustomize build . --stack-trace > sample.yaml

Which issue(s) this PR fixes:
Fixes #2061

Special notes for your reviewer:

/area provider/ibmcloud

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: priyanshikhetwani
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @priyanshikhetwani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	b591a65
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67494bf8e278c60008af57ca
😎 Deploy Preview	https://deploy-preview-2073--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Amulyam24]

/ok-to-test