Merge pull request #2772 from mac-chaffee/recreate

Changed the Deployment strategy to 'Recreate' so multiple external-dns pods don't conflict with each other.
kubernetes-sigs · Aug 10, 2022 · f10948e · f10948e
2 parents 5382a0a + 3d343ae
commit f10948e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/charts/external-dns/README.md b/charts/external-dns/README.md
@@ -69,3 +69,4 @@ The following table lists the configurable parameters of the _ExternalDNS_ chart
 | `domainFilters`                   | Limit possible target zones by domain suffixes.                                                                                                                                                                                                                                                                       | `[]`                                   |
 | `provider`                        | DNS provider where the DNS records will be created, for the available providers and how to configure them see the [README](https://github.com/kubernetes-sigs/external-dns#deploying-to-a-cluster).                                                                                                                   | `aws`                                  |
 | `extraArgs`                       | Extra arguments to pass to the _external-dns_ container, these are needed for provider specific arguments.                                                                                                                                                                                                            | `[]`                                   |
+| `deploymentStrategy`              | .spec.strategy of the external-dns Deployment. Defaults to 'Recreate' since multiple external-dns pods may conflict with each other.                                                                                                                                                                                  | `{type: Recreate}`                     |
diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
@@ -14,6 +14,8 @@ spec:
   selector:
     matchLabels:
       {{- include "external-dns.selectorLabels" . | nindent 6 }}
+  strategy:
+    {{- toYaml .Values.deploymentStrategy | nindent 4 }}
   template:
     metadata:
       labels:

diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml
@@ -125,3 +125,6 @@ domainFilters: []
 provider: aws
 
 extraArgs: []
+
+deploymentStrategy:
+  type: Recreate