add RBAC fix to namespaces - get, watch, list to each gateway-*route (#…

…4205) * add RBAC fix to namespaces - get, watch, list to each gateway-*route * fix conflicts * resolve conflicts * Apply suggestions from code review Co-authored-by: Steve Hipwell <[email protected]> --------- Co-authored-by: Steve Hipwell <[email protected]>
kubernetes-sigs · Jan 25, 2024 · fb87e34 · fb87e34
1 parent 8dd49cc
commit fb87e34
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/charts/external-dns/CHANGELOG.md b/charts/external-dns/CHANGELOG.md
@@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Fixed support for gateway-grpcroute, gateway-tlsroute, gateway-tcproute, gateway-udproute
+  https://github.com/kubernetes-sigs/external-dns/issues/3845 
 - Fix args for webhook deployment. ([#4202](https://github.com/kubernetes-sigs/external-dns/pull/4202))
 
 ## [v1.14.2] - 2024-01-22

diff --git a/charts/external-dns/templates/clusterrole.yaml b/charts/external-dns/templates/clusterrole.yaml
@@ -59,17 +59,15 @@ rules:
   - apiGroups: ["gateway.networking.k8s.io"]
     resources: ["gateways"]
     verbs: ["get","watch","list"]
+  - apiGroups: [""]
+    resources: ["namespaces"]
+    verbs: ["get","watch","list"]    
 {{- end }}
 {{- if has "gateway-httproute" .Values.sources }}
   - apiGroups: ["gateway.networking.k8s.io"]
     resources: ["httproutes"]
     verbs: ["get","watch","list"]
 {{- end }}
-{{- if has "gateway-httproute" .Values.sources }}
-  - apiGroups: [""]
-    resources: ["namespaces"]
-    verbs: ["get","watch","list"]
-{{- end }}
 {{- if has "gateway-grpcroute" .Values.sources }}
   - apiGroups: ["gateway.networking.k8s.io"]
     resources: ["grpcroutes"]