fix(ovh): cache refresh and duplicates processing

[nmaupu]

Description

• Cache was not updated when a change occurred which resulted in a change to be redone at each loop
• OVH DNS can have multiple times the exact same entry. Make sure we process all the IDs (instead of picking indefinitely the first one and trying to delete it multiple times resulting in 404).
• Using soft errors instead of hard errors

This PR Fixes all that and make the provider more resilient (all the errors were not soft resulting in the binary to exit).
This also makes #4844 irrelevant as this bug was produced by :

• the cache not being refreshed after changes.
• the list of duplicates not being processed correctly.

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Welcome @nmaupu!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @nmaupu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alexandrevilain]

Thanks @nmaupu !
We were having many issues since 0.15.0 with external-dns crashlooping. I tried a custom build based on your work and it works well.

[k8s-ci-robot]

@alexandrevilain: changing LGTM is restricted to collaborators

In response to this:

Thanks @nmaupu !
We were having many issues since 0.15.0 with external-dns crashlooping. I tried a custom build based on your work and it works well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nmaupu]

/assign @Raffo

[nmaupu]

Ping @mloiseleur @szuecs

[mloiseleur]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexandrevilain
Once this PR has been reviewed and has the lgtm label, please ask for approval from raffo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mloiseleur]

/retitle fix(ovh): cache refresh and duplicates processing

[mloiseleur]

@nmaupu It lgtm, see my last suggestion just to remove some (now) unneeded lines.

Btw, If you are interested, you can convert this provider into a webhook one. We have started the process to move the providers out of tree.

[nmaupu]

@nmaupu It lgtm, see my last suggestion just to remove some (now) unneeded lines.

Btw, If you are interested, you can convert this provider into a webhook one. We have started the process to move the providers out of tree.

Indeed, I will look into it when I get the chance !

[nmaupu]

/retest

[k8s-ci-robot]

@nmaupu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-external-dns-unit-test	ae4ebf5	link	true	/test pull-external-dns-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.