-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add F5 TransportServer source #4944
base: master
Are you sure you want to change the base?
feat: Add F5 TransportServer source #4944
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @visokoo! |
Hi @visokoo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mloiseleur just want to make sure it's on your radar. It's adding a new source. |
@visokoo Thanks for this PR. Would you please complete current documentation about F5 sources with this new source, and show how it works from user point of view ? |
/ok-to-test |
Added docs @mloiseleur, thank you for reviewing! |
The code lgtm. |
That's far better, thank you 👍 |
Description
Should completely fix: #2739 by adding in the
TransportServer
CRD as well. This is basically an exact copy of this PR from 2 yrs ago, but adds theTransportServer
instead. We can use the same code because theTransportServer
is essentially the same thing as theVirtualServer
, but it accepts other ports other than 80 and 443.Checklist