Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding initial docs infra #118

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Adding initial docs infra #118

merged 2 commits into from
Dec 19, 2024

Conversation

robscott
Copy link
Member

No real content yet, just the initial scaffolding and infra, largely inspired by Gateway API docs. Looks like this right now:

Screenshot 2024-12-19 at 11 54 55 AM

@k8s-ci-robot k8s-ci-robot requested a review from kfswain December 19, 2024 19:57
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 19, 2024
@robscott
Copy link
Member Author

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 19, 2024
@kfswain kfswain mentioned this pull request Dec 19, 2024
Open
@kfswain
Copy link
Contributor

kfswain commented Dec 19, 2024

/lgtm
/approve
/hold

I think it looks good! Most of this is boiler plate. Created: #120 for getting the image hosted.

Just holding in case any one else wants to review. @robscott feel free to unhold if you ready to submit this. Thanks a ton!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Dec 19, 2024

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2024
@robscott
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 60bab3a into kubernetes-sigs:main Dec 19, 2024
3 of 4 checks passed
@ahg-g ahg-g mentioned this pull request Dec 20, 2024
Open
@ahg-g
Copy link
Contributor

ahg-g commented Dec 20, 2024

Part of #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfswain kfswain Awaiting requested review from kfswain

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@ahg-g ahg-g

@kfswain kfswain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robscott @kfswain @k8s-ci-robot @ahg-g