-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding some initial docs content and diagrams #129
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Gateway API has [more than 25 | ||
implementations](https://gateway-api.sigs.k8s.io/implementations/). As this | ||
pattern stabilizes, we expect a wide set of these implementations to support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not clear what pattern this refers to, perhaps we should say the word pattern in the composable layer section intro so that the reader can connect the dots
## Composable Layers | ||
|
||
This project aims to develop an ecosystem of implementations that are fully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we mean by "ecosystem of implementations"? This project aims to "define specifications to enable a compatible ecosystem for extending the Gateway API with custom endpoint selection algorithms"?
|
||
As part of this project, we're building an initial reference extension that is | ||
focused on routing to LoRA workloads. Over time, we hope to see a wide variety |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer not to give the impression that this is centered on LoRA, in reality LoRA is just one of multiple criteria for selection.
[vLLM](https://github.com/vllm-project/vllm) and | ||
[Triton](https://github.com/triton-inference-server/server), and will be open to | ||
other integrations as they are requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of #72 |
Initial WIP attempt of some content for our docs.