-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added notifications in the common package #180
base: main
Are you sure you want to change the base?
Added notifications in the common package #180
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Devaansh-Kumar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Devaansh-Kumar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
f0bf4ab
to
26a0cf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tests for it
Could you tell how can we structure tests for this? |
a8f9f22
to
5a08a3c
Compare
5a08a3c
to
9988220
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds notifications from the common package
Which issue(s) this PR fixes:
This pull request addresses part of the issue described in #131
Does this PR introduce a user-facing change?:
/cc @mlavacca @LiorLieberman