Handling of kmm module ready label (kernel module is loaded) #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 80.14% 80.17% +0.03%
==========================================
Files 45 45
Lines 4513 4556 +43
==========================================
+ Hits 3617 3653 +36
- Misses 733 739 +6
- Partials 163 164 +1
☔ View full report in Codecov by Sentry. |
yevgeny-shnaidman
force-pushed
the
yevgeny/module-ready-label
branch
from
529f34f to
617431c
Compare
qbarrand
reviewed
Sep 25, 2023
This PR adds the ability to add/remove kmm.node.kubernetes.io/%s.%s.ready label to the node. This is done based on the current labels on the node, and the comparison between NMC module's spec and status. State machine for adding/removing: 1) if spec config and status config are not equal - node's label should stay as is (either present or missing) 2) if both spec and status are missing - node's label should be removed 3) if spec config and status config are equal - node's label should be set
yevgeny-shnaidman
force-pushed
the
yevgeny/module-ready-label
branch
from
617431c to
594eaec
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Nov 8, 2023
…tes-sigs#575) (kubernetes-sigs#788) This PR adds the ability to add/remove kmm.node.kubernetes.io/%s.%s.ready label to the node. This is done based on the current labels on the node, and the comparison between NMC module's spec and status. State machine for adding/removing: 1) if spec config and status config are not equal - node's label should stay as is (either present or missing) 2) if both spec and status are missing - node's label should be removed 3) if spec config and status config are equal - node's label should be set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add/remove
kmm.node.kubernetes.io/%s.%s.ready label to the node. This is done based on the current labels on the node, and the comparison between NMC module's spec and status. State machine for adding/removing: