Enhancement for redefining communication between Module-NMC and NMC

[yevgeny-shnaidman]

controllers

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yevgeny-shnaidman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-kmm ready!

Name	Link
🔨 Latest commit	1034648
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/6706acc6fe4e0f00088bba44
😎 Deploy Preview	https://deploy-preview-918--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.62%. Comparing base (fa23a9b) to head (1034648).
Report is 132 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
- Coverage   79.09%   72.62%   -6.48%     
==========================================
  Files          51       65      +14     
  Lines        5109     4493     -616     
==========================================
- Hits         4041     3263     -778     
- Misses        882     1045     +163     
+ Partials      186      185       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ybettan]

Should we just stop supporting Modules without the version field? Why do we keep supporting it?

[yevgeny-shnaidman]

not yet

…

On Wed, Oct 9, 2024 at 3:37 PM Yoni Bettan ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In docs/enhancements/0003-module-nmc-responsibilty-refactoring.md <#918 (comment)> : > +2. Eliminate race conditions which are the result of the current situation + +## Non-Goals + +Do not change any other functionality of the two operators, besides their decision making that is described above + +## Design + +### Module-NMC controller decision-making flow + +The flow takes into account both Module with Version field defined (ordered upgrade) and without Version field defined (un-ordered upgrade) +Module-NMC does not take into account the current state of the Node (Ready/NotReady/Schedulable/etc'). It just defines if the kernel module should +be loaded on the node or not based on whether there is a KernelMapping for the current node's kernel and on the labels of the node. All the rest of the decisions +will be taken by NMC reconciler, which has a much better view of Node's current state and kernel module's current state + +1. Found out all the nodes targeted by the Module regardless of node's status, based on the node selector field of the Module I still see the old version. Did you push? — Reply to this email directly, view it on GitHub <#918 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOPNM5MREQ5VEZ5HVM2ZDP3Z2UPQRAVCNFSM6AAAAABPR2YI7SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJXGAZDQNBUGY> . You are receiving this because you authored the thread.Message ID: <kubernetes-sigs/kernel-module-management/pull/918/review/2357028446@ github.com>

[ybettan]

/lgtm

[yevgeny-shnaidman]

/retest