Renaming the webhook deployment from webhook-server to webhook.

[ybettan]

• When we generate files with controller-gen it generates a service called webhook-service and it is not configurable.

• When we deploy KMM with OLM, OLM deploys a service for the webhook called <webhook-deployment-name>-service.

Therefore, before this change, we were getting 2 services for the same deployment. One generated by controller-gen and added to the bundle manifests and the other one created "on the fly" by OLM.

This change will make OLM find an already existing service called webhook-service in the cluster because the deployment is called webhook, therefore, it won't create a second service as before.

Services in KMM's namespace before the changes:

kmm-operator-controller-metrics-service   ClusterIP   10.129.169.25   <none>  8443/TCP   2d2h
kmm-operator-webhook-server-service       ClusterIP   10.130.107.158  <none>  443/TCP    2d2h
kmm-operator-webhook-service              ClusterIP   10.128.244.171  <none>  443/TCP    2d2h

Services in KMM's namespace after the changes:

kmm-operator-controller-metrics-service   ClusterIP   10.99.75.82     <none>  8443/TCP   88m
kmm-operator-webhook-service              ClusterIP   10.105.163.241  <none>  443/TCP    88m

---

/assign @yevgeny-shnaidman
/cc @TomerNewman

[k8s-ci-robot]

@ybettan: GitHub didn't allow me to request PR reviews from the following users: TomerNewman.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

• When we generate files with controller-gen it generates a service called webhook-service and it is not configurable.

• When we deploy KMM with OLM, OLM deploys a service for the webhook called `-service.

Therefore, before this change, we were getting 2 services for the same deployment. One generated by controller-gen and added to the bundle manifests and the other one created "on the fly" by OLM.

This change will make OLM find an already existing service called webhook-service in the cluster because the deployment is called webhook, therefore, it won't create a second service as before.

Services in KMM's namespace before the changes:

kmm-operator-controller-metrics-service   ClusterIP   10.129.169.25   <none>  8443/TCP   2d2h
kmm-operator-webhook-server-service       ClusterIP   10.130.107.158  <none>  443/TCP    2d2h
kmm-operator-webhook-service              ClusterIP   10.128.244.171  <none>  443/TCP    2d2h

Services in KMM's namespace after the changes:

kmm-operator-controller-metrics-service   ClusterIP   10.99.75.82     <none>  8443/TCP   88m
kmm-operator-webhook-service              ClusterIP   10.105.163.241  <none>  443/TCP    88m

---

/assign @yevgeny-shnaidman
/cc @TomerNewman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ybettan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-kmm ready!

Name	Link
🔨 Latest commit	b6f8178
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/67687aecfa24680008085476
😎 Deploy Preview	https://deploy-preview-957--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.68%. Comparing base (fa23a9b) to head (b6f8178).
Report is 160 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
- Coverage   79.09%   72.68%   -6.42%     
==========================================
  Files          51       65      +14     
  Lines        5109     5762     +653     
==========================================
+ Hits         4041     4188     +147     
- Misses        882     1395     +513     
+ Partials      186      179       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yevgeny-shnaidman]

/lgtm