Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wider #4274

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add wider #4274

wants to merge 2 commits into from

Conversation

boriscosic
Copy link

About

This plugin lets users query pod and associated node information with same command. There are multiple times when details of node, such as zone, provider etc need to be viewed alongside the pod and it requires two kubectl queries.

For example:
k wider -o custom-columns="NAME:.metadata.name,NODE:.node.metadata.name,IP:.status.hostIP,ZONE:.node.metadata.labels.topology\.kubernetes\.io/zone" -n kube-system -l k8s-app=kube-dns

NAME                      NODE                                          IP              ZONE
coredns-aaaaaaaaaa-mndf5  ip-10-111-222-333.us-west-2.compute.internal  10.111.122.162  us-west-2a
coredns-bbbbbbbbbb-sl7c5  ip-10-111-222-334.us-west-2.compute.internal  10.111.123.192  us-west-2b
coredns-cccccccccc-tpnxs  ip-10-111-222-335.us-west-2.compute.internal  10.111.124.250  us-west-2c

@ahmetb
Copy link
Member

ahmetb commented Dec 13, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: boriscosic
Once this PR has been reviewed and has the lgtm label, please assign chriskim06 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

linux-foundation-easycla bot commented Dec 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @boriscosic!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 13, 2024
@ahmetb
Copy link
Member

ahmetb commented Dec 13, 2024

Thanks for the submission.
I think the plugin is a little odd in the sense that it only works for pod/node and makes assumptions like there's a zone label (not everyone runs on cloud) —and the name wider sounds broad that I thought this is going to be somehow a better generic -o=wide output. I don't have better naming suggestions at this time, but I think the name is a bit misleading, don't you think?

@boriscosic
Copy link
Author

boriscosic commented Dec 13, 2024

Thanks @ahmetb the example is a bit unclear perhaps. The intent is to query pod + node information using -o custom-columns format, grabbing aspects of node output combined with pod.

wider is a play on expanded format provided by wide. Down the line I did consider the ability to extend to other resources but this was my immediate need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants