Remove krew support #11824
Open
Remove krew support #11824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-action-required
|
/ok-to-test |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
|
/approve cancel (apparently does not work in the PR body itself) |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
approved
|
/retest-failed |
|
It's added by #7464. HI @liupeng0518, how do you think about the change :-) |
k8s-ci-robot
added
the
needs-rebase
Krew is fundamentally to install kubectl plugins, which are eminently a client side things. It's also not difficult to install on a client machine.
VannTen
force-pushed
the
cleanup/remove_krew
branch
from
261cdd5 to
632b96e
Compare
k8s-ci-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In my opinion, installing krew does not belong in Kubespray: it's client-side, available in several package managers, and not a general tool for deploying (like helm, which we can use in kubespray itself).
Which issue(s) this PR fixes:
Special notes for your reviewer:
Feel free to express dissenting opinions on that subject ^^
/approve cancel
-> we should have a wider consensus for this
Does this PR introduce a user-facing change?: