Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cni-plugins] upgrade to stable 1.0.1 #8331

Merged
merged 2 commits into from
Dec 24, 2021
Merged

[cni-plugins] upgrade to stable 1.0.1 #8331

merged 2 commits into from
Dec 24, 2021

Conversation

cristicalin
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR upgrades CNI plugins to their stable 1.0.1 release.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
I think this should merge for 2.18 since it adds a stable version released quite some time ago (https://github.com/containernetworking/plugins/releases/tag/v1.0.1)

Does this PR introduce a user-facing change?:

[cni-plugins] upgrade to stable 1.0.1

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 22, 2021
@cristicalin
Copy link
Contributor Author

This should make it into #8325

@oomichi
Copy link
Contributor

oomichi commented Dec 22, 2021

Happy to see a new release with stable version of CNI :-)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2021
@jayonlau
Copy link
Contributor

/lgtm

floryut
floryut approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In time 😛

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2021
@cristicalin
Copy link
Contributor Author

This seems to break flannel and I'm not quite sure why so let's delay this PR for post 2.18.

/hold

/lgtm cancel

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 23, 2021
@cristicalin
Copy link
Contributor Author

Apparently with the 1.0 release, flannel was split to it's own separate project: https://github.com/flannel-io/cni-plugin. This change would actually require more work so definitely holding it off post 2.18.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 23, 2021
@cristicalin
Copy link
Contributor Author

In my local tests, the last change seems to have fixed the deployment, waiting for the CI to veto the change as well and maybe it's actually usable for 2.18. 🤞

@oomichi
Copy link
Contributor

oomichi commented Dec 23, 2021

@cristicalin
Thanks for fixing the issue.
Please drop the hold if this is ready.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2021
@cristicalin
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit ed3932b into kubernetes-sigs:master Dec 24, 2021
mircyb added a commit to mircyb/kubespray that referenced this pull request Jan 2, 2022
@mircyb
Update offline.yml
1e299bc 
[cni-plugins] upgrade to stable 1.0.1 (kubernetes-sigs#8331) using flannel cni add flannel_cni_download_url

flannel_cni_download_url offline doc update
@mircyb mircyb mentioned this pull request Jan 2, 2022
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jan 3, 2022
@mircyb
Update offline.yml (#8358)
8c67f42 
[cni-plugins] upgrade to stable 1.0.1 (#8331) using flannel cni add flannel_cni_download_url

flannel_cni_download_url offline doc update
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@cristicalin @sakuraiyuta
[cni-plugins] upgrade to stable 1.0.1 (kubernetes-sigs#8331)
5d2c278 
* [cni-plugins] upgrade to stable 1.0.1

* [flannel] use binary from dedicated project
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@mircyb @sakuraiyuta
Update offline.yml (kubernetes-sigs#8358)
95476fb 
[cni-plugins] upgrade to stable 1.0.1 (kubernetes-sigs#8331) using flannel cni add flannel_cni_download_url

flannel_cni_download_url offline doc update
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@cristicalin @LuckySB
[cni-plugins] upgrade to stable 1.0.1 (kubernetes-sigs#8331)
4d91bee 
* [cni-plugins] upgrade to stable 1.0.1

* [flannel] use binary from dedicated project
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@mircyb @LuckySB
Update offline.yml (kubernetes-sigs#8358)
09faefc 
[cni-plugins] upgrade to stable 1.0.1 (kubernetes-sigs#8331) using flannel cni add flannel_cni_download_url

flannel_cni_download_url offline doc update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@jayonlau jayonlau Awaiting requested review from jayonlau

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

@jayonlau jayonlau

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cristicalin @oomichi @jayonlau @k8s-ci-robot @floryut