Replace kube-rbac-proxy #284

anshuman-agarwala · 2024-12-16T07:09:04Z

What type of PR is this?

/kind deprecation

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #274

Special notes for your reviewer

Does this PR introduce a user-facing change?

k8s-ci-robot · 2024-12-16T07:09:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anshuman-agarwala
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-12-16T07:09:12Z

Welcome @anshuman-agarwala!

It looks like this is your first PR to kubernetes-sigs/lws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/lws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-12-16T07:09:13Z

Hi @anshuman-agarwala. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

camilamacedo86 · 2024-12-16T10:10:51Z

config/default/manager_metrics_service.yaml

+    protocol: TCP
+    targetPort: 8443
+  selector:
+    control-plane: controller-manager


NI: add an empty line at the end of the file

camilamacedo86 · 2024-12-16T10:10:57Z

config/rbac/auth_proxy_client_binding.yaml

+subjects:
+- kind: ServiceAccount
+  name: controller-manager
+  namespace: system


NI: add an empty line at the end of the file

kannon92 · 2024-12-16T13:24:24Z

/ok-to-test

thank you for taking this on!

k8s-ci-robot · 2024-12-17T06:19:28Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

camilamacedo86 · 2024-12-17T08:48:02Z

config/default/kustomization.yaml

@@ -25,13 +25,10 @@ resources:
 - ../internalcert
 # [PROMETHEUS] To enable prometheus monitor, uncomment all sections with 'PROMETHEUS'.
 #- ../prometheus
+# [METRICS] Expose the controller manager metrics service.
+- manager_metrics_service.yaml


@ahg-g @anshuman-agarwala

See that projects scaffolded with Kubebuilder now also have the default e2e tests generated:
https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4/test

The metrics can be used indeed to validate the reconciliations and etc

I would recommend you ensure that you also test it out in your tests.
See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/test/e2e/e2e_test.go#L166-L235

^ See here the tests to ensure the metrics endpoint
You might do not need the integration with prometheus. So, you could remove this block: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/test/e2e/e2e_test.go#L180-L183

camilamacedo86 · 2024-12-17T08:51:13Z

cmd/main.go

+	// Metrics endpoint is enabled in 'config/default/kustomization.yaml'. The Metrics options configure the server.
+	// More info:
+	// - https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/metrics/server
+	// - https://book.kubebuilder.io/reference/metrics.html
+	metricsServerOptions := metricsserver.Options{
+		BindAddress:    metricsAddr,
+		SecureServing:  true,
+		FilterProvider: filters.WithAuthenticationAndAuthorization,
+	}


Suggested change

// Metrics endpoint is enabled in 'config/default/kustomization.yaml'. The Metrics options configure the server.

// More info:

// - https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/metrics/server

// - https://book.kubebuilder.io/reference/metrics.html

metricsServerOptions := metricsserver.Options{

BindAddress: metricsAddr,

SecureServing: true,

FilterProvider: filters.WithAuthenticationAndAuthorization,

}

// if the enable-http2 flag is false (the default), http/2 should be disabled

// due to its vulnerabilities. More specifically, disabling http/2 will

// prevent from being vulnerable to the HTTP/2 Stream Cancellation and

// Rapid Reset CVEs. For more information see:

// - https://github.com/advisories/GHSA-qppj-fm5r-hxr3

// - https://github.com/advisories/GHSA-4374-p667-p6c8

disableHTTP2 := func(c *tls.Config) {

setupLog.Info("disabling http/2")

c.NextProtos = []string{"http/1.1"}

}

if !enableHTTP2 {

tlsOpts = append(tlsOpts, disableHTTP2)

}

// Metrics endpoint is enabled in 'config/default/kustomization.yaml'. The Metrics options configure the server.

// More info:

// - https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/metrics/server

// - https://book.kubebuilder.io/reference/metrics.html

metricsServerOptions := metricsserver.Options{

BindAddress: metricsAddr,

SecureServing: true,

FilterProvider: filters.WithAuthenticationAndAuthorization,

TLSOpts: tlsOpts,

}

You should not use HTTP/2
See that you should either use : https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/cmd/main.go#L95-L109

You might want to disable always and not add the flag

The fix for GRCP are not good enough: kubernetes/kubernetes#121197

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Dec 16, 2024

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2024

k8s-ci-robot requested review from ahg-g and Edwinhr716 December 16, 2024 07:09

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2024

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 16, 2024

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2024

Replace kube-rbac-proxy

2e310d1

anshuman-agarwala force-pushed the kube-rbac-proxy-replacement branch from f9154ba to 2e310d1 Compare December 16, 2024 07:16

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2024

camilamacedo86 reviewed Dec 16, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 16, 2024

anshuman-agarwala changed the title ~~[WIP] Replace kube-rbac-proxy~~ Replace kube-rbac-proxy Dec 16, 2024

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 16, 2024

camilamacedo86 reviewed Dec 17, 2024

View reviewed changes

ahg-g mentioned this pull request Dec 17, 2024

Remove kube-rbac-proxy kubernetes-sigs/jobset#722

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace kube-rbac-proxy #284

Replace kube-rbac-proxy #284

anshuman-agarwala commented Dec 16, 2024

k8s-ci-robot commented Dec 16, 2024

k8s-ci-robot commented Dec 16, 2024

k8s-ci-robot commented Dec 16, 2024

camilamacedo86 Dec 16, 2024

camilamacedo86 Dec 16, 2024

kannon92 commented Dec 16, 2024

k8s-ci-robot commented Dec 17, 2024

camilamacedo86 Dec 17, 2024

camilamacedo86 Dec 17, 2024

camilamacedo86 Dec 17, 2024

camilamacedo86 Dec 17, 2024

Replace kube-rbac-proxy #284

Are you sure you want to change the base?

Replace kube-rbac-proxy #284

Conversation

anshuman-agarwala commented Dec 16, 2024

What type of PR is this?

What this PR does / why we need it

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

k8s-ci-robot commented Dec 16, 2024

k8s-ci-robot commented Dec 16, 2024

k8s-ci-robot commented Dec 16, 2024

camilamacedo86 Dec 16, 2024

Choose a reason for hiding this comment

camilamacedo86 Dec 16, 2024

Choose a reason for hiding this comment

kannon92 commented Dec 16, 2024

k8s-ci-robot commented Dec 17, 2024

camilamacedo86 Dec 17, 2024

Choose a reason for hiding this comment

camilamacedo86 Dec 17, 2024

Choose a reason for hiding this comment

camilamacedo86 Dec 17, 2024

Choose a reason for hiding this comment

camilamacedo86 Dec 17, 2024

Choose a reason for hiding this comment