Skip to content

Commit

Permalink
fix release github action
Browse files Browse the repository at this point in the history
Signed-off-by: Xudong Liu <[email protected]>
  • Loading branch information
XudongLiuHarold committed Jun 14, 2024
1 parent d76ab69 commit 2268321
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 13 deletions.
32 changes: 19 additions & 13 deletions .github/workflows/generate-release-notes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,25 @@ jobs:
run: |
git fetch --tags --force
latest_tag=$(git tag --sort=-creatordate | head -n 1)
echo "latest release is ${latest_tag}"
echo "latest_tag=${latest_tag}" >> $GITHUB_OUTPUT
echo "valid=$(./hack/match-release-tag.sh ${latest_tag} >/dev/null 2>&1)" >> $GITHUB_OUTPUT
./hack/match-release-tag.sh ${latest_tag}
valid=$?
echo "valid release: ${valid}"
echo "valid=${valid}" >> $GITHUB_OUTPUT
- name: Find Second Latest Release Tag
if: ${{ steps.check.outputs.valid }}
if: ${{ steps.check.outputs.valid }} == 0
id: find
run: |
SEMVER_REGEX='^[[:space:]]{0,}v[[:digit:]]{1,}\.[[:digit:]]{1,}\.[[:digit:]]{1,}(-(alpha|beta|rc)\.[[:digit:]]{1,}){0,1}[[:space:]]{0,}$'
PRERELEASE_SEMVER_REGEX='^v?[0-9]+\.[0-9]+\.[0-9]+-[0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*$'
STABLE_RELEASE_SEMVER_REGEX='^v?[0-9]+\.[0-9]+\.[0-9]+$'
latest_tag=${{ steps.check.outputs.latest_tag }}
echo "latest release is ${latest_tag}"
if [[ latest_tag =~ ${PRERELEASE_SEMVER_REGEX} ]]; then
second_latest_release_tag=$(git tag --sort=-v:refname | grep -E ${SEMVER_REGEX} | awk 'p{print; exit} /${latest_tag}/{p=1}')
echo "${latest_tag} is a pre-release, return second latest release tag ${second_latest_release_tag}"
Expand All @@ -63,13 +69,13 @@ jobs:
echo "second_latest_release_tag=${second_latest_release_tag}" >> $GITHUB_OUTPUT
- name: Generate Release Note
if: ${{ steps.check.outputs.valid }}
run: |
if ${{ steps.find.outputs.pre_release}} >/dev/null 2>&1; then
gh release create ${{ steps.check.outputs.latest_tag }} --verify-tag --generate-notes --notes-start-tag ${{ steps.find.outputs.second_latest_release_tag }} --prerelease
else
gh release create ${{ steps.check.outputs.latest_tag }} --verify-tag --generate-notes --notes-start-tag ${{ steps.find.outputs.second_latest_release_tag }}
fi
env:
GH_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
# - name: Generate Release Note
# if: ${{ steps.check.outputs.valid }} == 0
# run: |
# if ${{ steps.find.outputs.pre_release}} >/dev/null 2>&1; then
# gh release create ${{ steps.check.outputs.latest_tag }} --verify-tag --generate-notes --notes-start-tag ${{ steps.find.outputs.second_latest_release_tag }} --prerelease
# else
# gh release create ${{ steps.check.outputs.latest_tag }} --verify-tag --generate-notes --notes-start-tag ${{ steps.find.outputs.second_latest_release_tag }}
# fi
# env:
# GH_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
3 changes: 3 additions & 0 deletions hack/match-release-tag.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,13 @@ REGEX='^[[:space:]]{0,}v[[:digit:]]{1,}\.[[:digit:]]{1,}\.[[:digit:]]{1,}(-(alph
# Match the tag against the regular expression for a release tag.
match() {
if [[ ${1} =~ ${REGEX} ]]; then
exit_code="${?}"
echo "yay: ${1}"
echo "${exit_code}"
else
exit_code="${?}"
echo "nay: ${1}"
echo "${exit_code}"
return "${exit_code}"
fi
}
Expand Down

0 comments on commit 2268321

Please sign in to comment.