-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Document client-body-timeout
annotation.
#12521
base: main
Are you sure you want to change the base?
Conversation
Client body timeout is currently documented only as configmap but it is supported as nginx ingress annotation
The committers listed above are authorized under a signed CLA. |
Welcome @sjlawton! |
Hi @sjlawton. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sjlawton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `nginx.ingress.kubernetes.io/client-body-timeout` | ||
|
||
Defines a timeout for reading client request body, in seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you maybe add this as a separate section after client-body-buffer-size
.
/triage accepted |
client-body-timeout
annotation.
@@ -48,6 +48,7 @@ You can add these Kubernetes annotations to specific Ingress objects to customiz | |||
|[nginx.ingress.kubernetes.io/canary-weight](#canary)|number| | |||
|[nginx.ingress.kubernetes.io/canary-weight-total](#canary)|number| | |||
|[nginx.ingress.kubernetes.io/client-body-buffer-size](#client-body-buffer-size)|string| | |||
|[nginx.ingress.kubernetes.io/client-body-timeout](#custom-timeouts)[number]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|[nginx.ingress.kubernetes.io/client-body-timeout](#custom-timeouts)[number]: | |
|[nginx.ingress.kubernetes.io/client-body-timeout](#client-body-timeout)|number| |
Client body timeout is currently documented only as configmap but it is supported as nginx ingress annotation
What this PR does / why we need it:
Solves annotation that is missing from documentation
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Pure documentation change
Checklist: