-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chris Kim as Krew maintainer #2238
Conversation
Hi @corneliusweig. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I second this proposal, Chris has shown initiative outside his initial work area that helps krew project. |
👍 from me as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusweig, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-org-test-all |
/lgtm |
Chris has been taking on a pretty active role in Krew over the past 6 months. He was the primary driver of implementing decentralized plugin repositories in krew (meta-issue, issues & PRs).
Since the successful launch of this feature he continued his work on krew through PR reviews and fixes.
Chris should therefore have maintainer rights for krew, so that he can continue his work more efficiently.
@chriskim06
@ahmetb