Skip to content

Commit

Permalink
jobs: avoid blocking job which doesn't always run
Browse files Browse the repository at this point in the history
As bentheelder said on
Slack (https://kubernetes.slack.com/archives/C2C40FMNF/p1734418617113169?thread_ts=1734417601.687079&cid=C2C40FMNF),
"adding blocking tests that only sometimes run is confusing and doesn't work
well".

That's because a regression might get merged without running the job. Then
any PR where the job gets run is blocked, whether it is related to the failure
or not.

Therefore pull-kubernetes-e2e-gce-network-proxy-http-connect should not be
blocking.
  • Loading branch information
pohly committed Dec 17, 2024
1 parent 98992df commit 88405ac
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ presubmits:
cluster: k8s-infra-prow-build
always_run: false
run_if_changed: '^(cluster/gce/manifests/konnectivity-server.yaml$|cluster/gce/addons/konnectivity-agent)'
optional: true # Doesn't always run and regressions shouldn't block merging PRs where it gets run.
labels:
preset-service-account: "true"
preset-k8s-ssh: "true"
Expand Down

0 comments on commit 88405ac

Please sign in to comment.