-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge cert-manager's testgrid config #26209
Conversation
Signed-off-by: Richard Wall <[email protected]>
Hi @wallrj. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The configuration has now been uploaded to a bucket by a ProwJob (this is not publicly accessible, so I cannot link it). |
Not-publicly-accessible is fine, so long as permissions are granted as outlined in merging.md Also keep in mind that, although the bucket or file are not publicly readable, you are asking TestGrid to display the contents of this config file to everyone. https://testgrid.k8s.io/ is quite public. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chases2, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Nice to see that this got merged 🙏🏼
We've given We're okay with TestGrid being public (more pressure on us to keep those jobs green :) ), it's just the least privilege principle for the bucket. I've had a look at our TestGrid and it looks like it hasn't been updated yet with the config from the bucket- where would we be able to see what happened after this PR got merged, was there a job that ran with Config Merger trying to access our bucket? |
Hi @chases2 thanks a lot for your help with this! It looks like so far our TestGrid has not yet been updated with the latest config since merging this PR. Is there somewhere we could look to see if there are any issues with the configuration? I see that there are some older issues that talk about needing to restart Config Merger controller, but I am guessing this is no longer the case GoogleCloudPlatform/testgrid#517 ? |
We're configuring cert-manager Prow to upload testgrid configs using config merger.
We've created a GCP bucket with read-access from the Kubernetes testgrid service accounts
We're ironing out some problems with the uploading, but once we've got it working this can be reviewed and merged.
Part of: