Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge cert-manager's testgrid config #26209

Merged
merged 1 commit into from
May 12, 2022

Conversation

wallrj
Copy link
Contributor

@wallrj wallrj commented May 5, 2022

We're configuring cert-manager Prow to upload testgrid configs using config merger.
We've created a GCP bucket with read-access from the Kubernetes testgrid service accounts

We're ironing out some problems with the uploading, but once we've got it working this can be reviewed and merged.

Part of:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @wallrj. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels May 5, 2022
@k8s-ci-robot k8s-ci-robot requested review from chases2 and spiffxp May 5, 2022 10:23
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 5, 2022
@chases2 chases2 self-assigned this May 6, 2022
@irbekrm
Copy link
Contributor

irbekrm commented May 12, 2022

The configuration has now been uploaded to a bucket by a ProwJob (this is not publicly accessible, so I cannot link it).

@wallrj wallrj changed the title WIP: Merge cert-manager's testgrid config Merge cert-manager's testgrid config May 12, 2022
@wallrj wallrj marked this pull request as ready for review May 12, 2022 08:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2022
@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t May 12, 2022 08:29
@chases2
Copy link
Contributor

chases2 commented May 12, 2022

Not-publicly-accessible is fine, so long as permissions are granted as outlined in merging.md

Also keep in mind that, although the bucket or file are not publicly readable, you are asking TestGrid to display the contents of this config file to everyone. https://testgrid.k8s.io/ is quite public.

/approve
/lgtm
/hold for ack
/ok-to-test

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@wallrj
Copy link
Contributor Author

wallrj commented May 12, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2a02ac3 into kubernetes:master May 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 12, 2022
@irbekrm
Copy link
Contributor

irbekrm commented May 13, 2022

Nice to see that this got merged 🙏🏼

Not-publicly-accessible is fine, so long as permissions are granted as outlined in merging.md
Also keep in mind that, although the bucket or file are not publicly readable, you are asking TestGrid to display the contents of this config file to everyone. https://testgrid.k8s.io/ is quite public.

We've given storage.objectViewer role to [email protected] and [email protected].

We're okay with TestGrid being public (more pressure on us to keep those jobs green :) ), it's just the least privilege principle for the bucket.

I've had a look at our TestGrid and it looks like it hasn't been updated yet with the config from the bucket- where would we be able to see what happened after this PR got merged, was there a job that ran with Config Merger trying to access our bucket?

@wallrj wallrj deleted the cert-manager-test-grid branch May 13, 2022 10:35
@irbekrm
Copy link
Contributor

irbekrm commented Jun 7, 2022

Hi @chases2 thanks a lot for your help with this!

It looks like so far our TestGrid has not yet been updated with the latest config since merging this PR. Is there somewhere we could look to see if there are any issues with the configuration?

I see that there are some older issues that talk about needing to restart Config Merger controller, but I am guessing this is no longer the case GoogleCloudPlatform/testgrid#517 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants