refactor: cleanup

kunkunsh · Nov 3, 2024 · fa5f7ec · fa5f7ec
1 parent 97499e8
commit fa5f7ec
Show file tree

Hide file tree

Showing 9 changed files with 5 additions and 20 deletions.
diff --git a/apps/desktop/src/lib/components/main/CommandPalette.svelte b/apps/desktop/src/lib/components/main/CommandPalette.svelte
@@ -1,4 +1,7 @@
 <!-- This file renders the main command palette, a list of commands -->
+<!-- This is not placed in @kksh/ui because it depends on the app config and is very complex, 
+passing everything through props will be very complicated and hard to maintain.
+-->
 <script lang="ts">
 	import type { ExtPackageJsonExtra } from "@kksh/api/models"
 	import { isExtPathInDev } from "@kksh/extension/utils"
@@ -29,10 +32,6 @@
 		appState: Writable<AppState>
 		builtinCmds: BuiltinCmd[]
 	} = $props()
-	// const appConfig = getAppConfigContext()
-
-	let highlightedCmd = $state("")
-	let searchTerm = $state("")
 </script>
 
 <Command.Root

diff --git a/apps/desktop/src/lib/utils.ts b/apps/desktop/src/lib/utils.ts
diff --git a/apps/desktop/src/routes/extension/ui-iframe/+page.svelte b/apps/desktop/src/routes/extension/ui-iframe/+page.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
 	import { appConfig, winExtMap } from "@/stores"
-	import { cn } from "@/utils"
+	import { cn } from "@kksh/ui/utils"
 	import { goBackOnEscape } from "@/utils/key"
 	import { goHome } from "@/utils/route"
 	import { positionToTailwindClasses } from "@/utils/style"

diff --git a/apps/desktop/static/favicon.png b/apps/desktop/static/favicon.png
diff --git a/apps/desktop/static/logo-w-bg.png b/apps/desktop/static/logo-w-bg.png
diff --git a/apps/desktop/static/svelte.svg b/apps/desktop/static/svelte.svg
diff --git a/apps/desktop/static/tauri.svg b/apps/desktop/static/tauri.svg
diff --git a/apps/desktop/static/vite.svg b/apps/desktop/static/vite.svg
diff --git a/packages/ui/src/components/main/GlobalCommandPaletteFooter.svelte b/packages/ui/src/components/main/GlobalCommandPaletteFooter.svelte
@@ -7,6 +7,6 @@
 
 <footer data-tauri-drag-region class={cn("h-12 border-t", className)}>
 	<Avatar.Root class="p-2">
-		<Avatar.Image src="/logo-w-bg.png" alt="Kunkun Logo" class="select-none invert dark:invert-0" />
+		<Avatar.Image src="/favicon.png" alt="Kunkun Logo" class="select-none invert dark:invert-0" />
 	</Avatar.Root>
 </footer>