fix copying custom manifests

[simonfelding]

Description

Copying custom manifests didn't actually work with j2 templates.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

executed the code and copied a file over

[MonolithProjects]

It can be also yaml or yml.

ansible.builtin.template will template file with any file extension. The .j2 is not mandatory. You may use just .yaml and the file will be still templated if there is a Jinja2 syntax in it.

This option was meant to be used for files with yaml (or yml) files. But user could use Jinja2 syntax in it and it would be templated.

The actual bug here is that if the user will add .j2 file extension to the manifest file, the file will end up with .j2 also on the RKE2 server.

[simonfelding]

Ahh, good point. Will fix.

[MonolithProjects]

It can be also yaml or yml.

ansible.builtin.template will template file with any file extension. The .j2 is not mandatory. You may use just .yaml and the file will be still templated if there is a Jinja2 syntax in it.

This option was meant to be used for files with yaml (or yml) files. But user could use Jinja2 syntax in it and it would be templated.

The actual bug here is that if the user will add .j2 file extension to the manifest file, the file will end up with .j2 also on the RKE2 server.

[MonolithProjects]

I thin't it's better to keep it as a list of manifests. They can be in different folders or subfolders

[MonolithProjects]

I thin't it's better to keep it as a list of manifests. They can be in different folders or subfolders

[MonolithProjects]

I thin't it's better to keep it as a list of manifests. They can be in different folders or subfolders

[simonfelding]

Makes sense. I guess you could have {{ query('fileglob', rke2_custom_manifests + '/*') }} as an example instead.

[maxisam]

well, i think this is outdated

ansible-role-rke2/tasks/rke2.yml

Lines 252 to 259 in 859a27f

	- name: Copy Custom Manifests
	ansible.builtin.template:
	src: "{{ item }}"
	dest: "{{ rke2_data_path }}/server/manifests/{{ item | basename | regex_replace('\\.j2$', '') }}"
	owner: root
	group: root
	mode: 0644
	with_fileglob: "{{ rke2_custom_manifests }}/*"

[simonfelding]

well, i think this is outdated

ansible-role-rke2/tasks/rke2.yml

Lines 252 to 259 in 859a27f

	- name: Copy Custom Manifests
	ansible.builtin.template:
	src: "{{ item }}"
	dest: "{{ rke2_data_path }}/server/manifests/{{ item | basename | regex_replace('\\.j2$', '') }}"
	owner: root
	group: root
	mode: 0644
	with_fileglob: "{{ rke2_custom_manifests }}/*"

Yep - with the same code I wrote! So now it includes the glob functionality that @MonolithProjects said he didn't want to implement. Was that on purpose?

[MonolithProjects]

No @simonfelding, i overlooked it. Seems like you included the code in #260 . Will check it tomorrow as it is probably breaking the Custom Manifests (#285)

[MonolithProjects]

This was fixed in #290. Closing this PR.