Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support added #341

Closed
wants to merge 17 commits into from
Closed

Conversation

cod43156
Copy link

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Signed-off-by: Raj Mohan <[email protected]>
renovate bot added 3 commits November 8, 2024 14:19
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes made to the documentation affect the output and are therefore incorrect.

Signed-off-by: Raj Mohan <[email protected]>
@cod43156
Copy link
Author

@froschdesign Whenever you have some free time, I'd really appreciate it if you could take a look at the doc lint fixes.

@gsteel
Copy link
Member

gsteel commented Nov 25, 2024

Requires #351 - at the moment this patch would fail because deprecations are not being reported by tests

@gsteel gsteel mentioned this pull request Nov 25, 2024
@gsteel gsteel self-assigned this Nov 26, 2024
@gsteel
Copy link
Member

gsteel commented Nov 26, 2024

Thanks @cod43156 - This has been handled in #352

@gsteel gsteel closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants