Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General QA, Cleanup and Type Inference Improvements #18

Merged
merged 9 commits into from
Dec 5, 2024
Merged

General QA, Cleanup and Type Inference Improvements #18

merged 9 commits into from
Dec 5, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Dec 5, 2024

Q A
QA yes

Description

  • Add Psalm
  • Upgrade coding standard to 3.x
  • Fix docs workflow
  • setup renovate
  • drop the auto-closer
  • minor tweaks to dot files and tool config
  • Squash a tonne of psalm issues and baseline the rest

@gsteel gsteel added Enhancement QA Quality assurance tasks such as static analysis improvements labels Dec 5, 2024
@gsteel gsteel added this to the 2.13.0 milestone Dec 5, 2024
@gsteel gsteel requested a review from weierophinney December 5, 2024 21:08
gsteel added 7 commits December 5, 2024 21:08
@gsteel
Update dot files
d9bc416 
Signed-off-by: George Steel <[email protected]>
@gsteel
Bump dev deps and introduce psalm
277b5c0 
Signed-off-by: George Steel <[email protected]>
@gsteel
Update tool configuration
3905a27 
Signed-off-by: George Steel <[email protected]>
@gsteel
Setup renovate
01b4e60 
Signed-off-by: George Steel <[email protected]>
@gsteel
General QA
ac5bf6f 
- Reduce Psalm issues
- Upgrade Laminas Coding Standard
- Baseline remaining psalm issues
- `ExceptionInterface` should extend from `Throwable`

Signed-off-by: George Steel <[email protected]>
@gsteel
Drop the auto-closer
5894052 
Signed-off-by: George Steel <[email protected]>
@gsteel
Update docs-build workflow
404f613 
Signed-off-by: George Steel <[email protected]>
@gsteel
Copy link
Member Author

gsteel commented Dec 5, 2024

The BC breaks are due to ExceptionInterface inheriting from Throwable which is really more of a bug fix!

@froschdesign
Copy link
Member

The BC breaks are due to ExceptionInterface inheriting from Throwable which is really more of a bug fix!

Would you still like to release it?

@gsteel
Copy link
Member Author

gsteel commented Dec 5, 2024

Would you still like to release it?

Well, we're not abandoning it now, so we might as well clean things up a bit!

@froschdesign
Copy link
Member

I mean the BC breaks.

@gsteel
Copy link
Member Author

gsteel commented Dec 5, 2024

Oh yeah. I've released loads of minors with this change. It's only a technical bc break. It won't break anyone's project 👍

froschdesign
froschdesign approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it! 👍🏻

@gsteel gsteel self-assigned this Dec 5, 2024
@gsteel gsteel merged commit c867c60 into laminas:2.13.x Dec 5, 2024
16 of 17 checks passed
@gsteel gsteel deleted the cleanup branch December 5, 2024 22:18
@gsteel gsteel changed the title General QA and Cleanup General QA, Cleanup and Type Inference Improvements Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froschdesign froschdesign froschdesign approved these changes

@weierophinney weierophinney Awaiting requested review from weierophinney

Assignees

@gsteel gsteel

Labels
Enhancement QA Quality assurance tasks such as static analysis improvements
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteel @froschdesign