Update Menu.php #233
Open
Update Menu.php #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The consumption of the findActive function may be conditioned on the $onlyActive variable since the use of the $foundPage and $foundDepth variables within foreach is also Signed-off-by: Tarcisio Cesar <[email protected]>
Correcting indentation Signed-off-by: Tarcisio Cesar <[email protected]>
Signed-off-by: Tarcisio Cesar <[email protected]>
Signed-off-by: Tarcisio Cesar <[email protected]>
Ocramius
requested changes
Jan 24, 2024
Comment on lines
+279
to
286
| if ($onlyActive) { | ||
| // find deepest active | ||
| $found = $this->findActive($container, $minDepth, $maxDepth); | ||
| if ($found) { | ||
| $foundPage = $found['page']; | ||
| $foundDepth = $found['depth']; | ||
| } | ||
| } |
There was a problem hiding this comment.
Please do add a test to verify these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consumption of the findActive function may be conditioned on the $onlyActive variable since the use of the $foundPage and $foundDepth variables within foreach is also.
In applications with many pages, if you do not use the onlyActive option, the return time can be optimized by conditioning the findActive method call
Description